Skip to content

fix(ui): Plain text crashes verification window - #6799

Closed
hdost wants to merge 1 commit into
akuity:mainfrom
hdost:fix-verifications
Closed

fix(ui): Plain text crashes verification window#6799
hdost wants to merge 1 commit into
akuity:mainfrom
hdost:fix-verifications

Conversation

@hdost

@hdost hdost commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown

When you have a check which is basic text Kargo is trying to parse it as JSON, but for plain text that fails, meaning that then you can't view the result. This fails safely back to just returning the basic value.

Description

Closes #4630

Checklist

Eligibility

  • Linked to an existing issue with no blocking labels (kind/proposal, needs discussion, needs research, maintainer only, area/security, size/large, size/x-large, size/xx-large).
  • Changes documentation only.
  • Changes ten lines or fewer.

Quality

  • Adds or updates corresponding tests.
  • Adds or updates corresponding documentation.

AI Use Disclosure

This PR was written:

  • By a human without AI assistance.
  • By a human with AI assistance. A human has reviewed every line prior to opening the PR.
  • By an AI with human supervision. A human has reviewed every line prior to opening the PR.
  • Entirely by an AI. No human has reviewed this prior to opening the PR.

Sign-Off

All commits:

  • Are signed off by their author (git commit -s) (required)
  • Are cryptographically signed (git commit -S) (encouraged)

@hdost
hdost requested a review from a team as a code owner August 12, 2026 14:08
@kargo-governance-bot kargo-governance-bot Bot added kind/bug Something isn't working as intended; If unsure that something IS a bug, start a discussion instead needs/area Issue or PR needs to be labeled to indicate what parts of the code base are affected needs/priority Priority has not yet been determined; a good signal that maintainers aren't fully committed labels Aug 12, 2026
@netlify

netlify Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit ba0ce4d
🔍 Latest deploy log https://app.netlify.com/projects/docs-kargo-io/deploys/6a7c7e9f40e508000862f15b
😎 Deploy Preview https://deploy-preview-6799.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hdost
fix(ui): Plain text crashes verification window
ba0ce4d 
When you have a check which is basic text Kargo is trying to parse it as
JSON, but for plain text that fails, meaning that then you can't view
the result. This fails safely back to just returning the basic value.

Signed-off-by: Harold Dost III <harold.dost@mistral.ai>
@hdost
hdost force-pushed the fix-verifications branch from 5ccd965 to ba0ce4d Compare August 12, 2026 14:09
@hdost hdost mentioned this pull request Aug 18, 2026
Merged
11 tasks
@hdost hdost closed this Aug 24, 2026
@hdost

hdost commented Aug 24, 2026

Copy link
Copy Markdown
Author

Duplicate #6758

@hdost
hdost deleted the fix-verifications branch August 24, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@hdost hdost

Labels

kind/bug Something isn't working as intended; If unsure that something IS a bug, start a discussion instead needs/area Issue or PR needs to be labeled to indicate what parts of the code base are affected needs/priority Priority has not yet been determined; a good signal that maintainers aren't fully committed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot view AnalysisRun result in UI - not a valid JSON

1 participant

@hdost